ERP5Form: implement a basic _checkConsistency for ProxyField WIP

product/ERP5Form/Form.py

@@ -1386,6 +1386,13 @@ class ERP5Form(Base, ZMIForm, ZopePageTemplate):
                   addMessage(
                       'erp5-Guideline.Use.Correct.Names.For.Simulation.And.Validation.Titles',
                       'Workflow state fields should be named my_translated_${state_variable}_title')
+
+      # check fields, if they implement _checkConsistency
+      for field in self.objectValues():
+        _checkConsitency = getattr(field, '_checkConsistency', None)
+        if _checkConsitency is not None:
+          message_list.extend(_checkConsitency(fixit=fixit))
+
       return message_list
 
 

product/ERP5Form/ProxyField.py

@@ -35,6 +35,7 @@ from Products.Formulator.Errors import ValidationError
 from Products.Formulator import MethodField
 from Products.ERP5Type.Utils import convertToUpperCase
 from Products.ERP5Type.TransactionalVariable import getTransactionalVariable
+from Products.ERP5Type.ObjectMessage import ObjectMessage
 
 from Products.PageTemplates.PageTemplateFile import PageTemplateFile
 
@@ -790,6 +791,19 @@ class ProxyField(ZMIField):
         return cache.__of__(parent)
     raise KeyError
 
+  def _checkConsistency(self, fixit=False):
+    """Check the proxy field internal data structures are consistent
+    """
+    object_relative_url = '/'.join(self.getPhysicalPath())[len(self.getPortalObject().getPath()):]
+    difference = set(self.tales).difference(self.values)
+    assert not fixit, "todo"
+    if difference:
+      return [
+        ObjectMessage(
+             object_relative_url=object_relative_url,
+             message="Internal proxy field data structures are inconsistent. "
+                     "Differences: {}".format(difference))]
+    return []
 
 #
 # get_value exception dict