erp5_base: add a post_upgrade constraint in Template Tool to setup ERP5LoginUserManager if missing.

bt5/erp5_base/PortalTypePropertySheetTemplateItem/property_sheet_list.xml

@@ -19,4 +19,7 @@
  <portal_type id="Query">
   <item>TextDocument</item>
  </portal_type>
+ <portal_type id="Template Tool">
+  <item>TemplateToolERP5LoginUserManagerConstraint</item>
+ </portal_type>
 </property_sheet_list>
\ No newline at end of file

bt5/erp5_base/PropertySheetTemplateItem/portal_property_sheets/TemplateToolERP5LoginUserManagerConstraint.xml

+<?xml version="1.0"?>
+<ZopeData>
+  <record id="1" aka="AAAAAAAAAAE=">
+    <pickle>
+      <global name="Property Sheet" module="erp5.portal_type"/>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>_count</string> </key>
+            <value>
+              <persistent> <string encoding="base64">AAAAAAAAAAI=</string> </persistent>
+            </value>
+        </item>
+        <item>
+            <key> <string>_mt_index</string> </key>
+            <value>
+              <persistent> <string encoding="base64">AAAAAAAAAAM=</string> </persistent>
+            </value>
+        </item>
+        <item>
+            <key> <string>_tree</string> </key>
+            <value>
+              <persistent> <string encoding="base64">AAAAAAAAAAQ=</string> </persistent>
+            </value>
+        </item>
+        <item>
+            <key> <string>description</string> </key>
+            <value>
+              <none/>
+            </value>
+        </item>
+        <item>
+            <key> <string>id</string> </key>
+            <value> <string>TemplateToolERP5LoginUserManagerConstraint</string> </value>
+        </item>
+        <item>
+            <key> <string>portal_type</string> </key>
+            <value> <string>Property Sheet</string> </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+  <record id="2" aka="AAAAAAAAAAI=">
+    <pickle>
+      <global name="Length" module="BTrees.Length"/>
+    </pickle>
+    <pickle> <int>0</int> </pickle>
+  </record>
+  <record id="3" aka="AAAAAAAAAAM=">
+    <pickle>
+      <global name="OOBTree" module="BTrees.OOBTree"/>
+    </pickle>
+    <pickle>
+      <none/>
+    </pickle>
+  </record>
+  <record id="4" aka="AAAAAAAAAAQ=">
+    <pickle>
+      <global name="OOBTree" module="BTrees.OOBTree"/>
+    </pickle>
+    <pickle>
+      <none/>
+    </pickle>
+  </record>
+</ZopeData>

bt5/erp5_base/PropertySheetTemplateItem/portal_property_sheets/TemplateToolERP5LoginUserManagerConstraint/ERP5LoginUserNamager%20Existence_constraint.xml

+<?xml version="1.0"?>
+<ZopeData>
+  <record id="1" aka="AAAAAAAAAAE=">
+    <pickle>
+      <global name="Script Constraint" module="erp5.portal_type"/>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>_identity_criterion</string> </key>
+            <value>
+              <persistent> <string encoding="base64">AAAAAAAAAAI=</string> </persistent>
+            </value>
+        </item>
+        <item>
+            <key> <string>_range_criterion</string> </key>
+            <value>
+              <persistent> <string encoding="base64">AAAAAAAAAAM=</string> </persistent>
+            </value>
+        </item>
+        <item>
+            <key> <string>categories</string> </key>
+            <value>
+              <tuple>
+                <string>constraint_type/post_upgrade</string>
+              </tuple>
+            </value>
+        </item>
+        <item>
+            <key> <string>description</string> </key>
+            <value>
+              <none/>
+            </value>
+        </item>
+        <item>
+            <key> <string>id</string> </key>
+            <value> <string>ERP5LoginUserNamager Existence_constraint</string> </value>
+        </item>
+        <item>
+            <key> <string>portal_type</string> </key>
+            <value> <string>Script Constraint</string> </value>
+        </item>
+        <item>
+            <key> <string>script_id</string> </key>
+            <value> <string>TemplateTool_checkERP5LoginUserManagerExistenceConsistency</string> </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+  <record id="2" aka="AAAAAAAAAAI=">
+    <pickle>
+      <global name="PersistentMapping" module="Persistence.mapping"/>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>data</string> </key>
+            <value>
+              <dictionary/>
+            </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+  <record id="3" aka="AAAAAAAAAAM=">
+    <pickle>
+      <global name="PersistentMapping" module="Persistence.mapping"/>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>data</string> </key>
+            <value>
+              <dictionary/>
+            </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+</ZopeData>

bt5/erp5_base/SkinTemplateItem/portal_skins/erp5_base/TemplateTool_checkERP5LoginUserManagerExistenceConsistency.py

+acl_users = context.getPortalObject().acl_users
+plugin_id = 'erp5_login_users'
+error_list = []
+if plugin_id not in acl_users.objectIds():
+  error_list.append('ERP5 Login User Manager does not exist as %s/%s' % (acl_users.getPath(), plugin_id))
+  if fixit:
+    acl_users.manage_addProduct['ERP5Security'].addERP5LoginUserManager(plugin_id)
+    getattr(acl_users, plugin_id).manage_activateInterfaces([
+      'IAuthenticationPlugin',
+      'IUserEnumerationPlugin',
+    ])
+return error_list

bt5/erp5_base/SkinTemplateItem/portal_skins/erp5_base/TemplateTool_checkERP5LoginUserManagerExistenceConsistency.xml

+<?xml version="1.0"?>
+<ZopeData>
+  <record id="1" aka="AAAAAAAAAAE=">
+    <pickle>
+      <global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>Script_magic</string> </key>
+            <value> <int>3</int> </value>
+        </item>
+        <item>
+            <key> <string>_bind_names</string> </key>
+            <value>
+              <object>
+                <klass>
+                  <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
+                </klass>
+                <tuple/>
+                <state>
+                  <dictionary>
+                    <item>
+                        <key> <string>_asgns</string> </key>
+                        <value>
+                          <dictionary>
+                            <item>
+                                <key> <string>name_container</string> </key>
+                                <value> <string>container</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_context</string> </key>
+                                <value> <string>context</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_m_self</string> </key>
+                                <value> <string>script</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_subpath</string> </key>
+                                <value> <string>traverse_subpath</string> </value>
+                            </item>
+                          </dictionary>
+                        </value>
+                    </item>
+                  </dictionary>
+                </state>
+              </object>
+            </value>
+        </item>
+        <item>
+            <key> <string>_params</string> </key>
+            <value> <string>fixit=False</string> </value>
+        </item>
+        <item>
+            <key> <string>id</string> </key>
+            <value> <string>TemplateTool_checkERP5LoginUserManagerExistenceConsistency</string> </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+</ZopeData>

bt5/erp5_base/bt/template_path_list

-portal_alarms/upgrader_migrate_to_embedded_file
 portal_alarms/check_duplicate_login_reference
+portal_alarms/upgrader_migrate_to_embedded_file
 portal_caches/document_cache_factory
 portal_caches/document_cache_factory/**
 portal_categories/collect_order_group/cell

bt5/erp5_base/bt/template_portal_type_property_sheet_list

@@ -5,4 +5,5 @@ Person | DefaultImage
 Person | PersonUpgradeConstraint
 Preference | TelephonePreference
 Previous Causality Movement Group | PreviousCausalityMovementGroup
-Query | TextDocument
+Query | TextDocument
\ No newline at end of file
+Template Tool | TemplateToolERP5LoginUserManagerConstraint
\ No newline at end of file

bt5/erp5_base/bt/template_property_sheet_id_list

 LoginConstraint
 PersonUpgradeConstraint
-PreviousCausalityMovementGroup
+PreviousCausalityMovementGroup
\ No newline at end of file
+TemplateToolERP5LoginUserManagerConstraint
\ No newline at end of file

product/ERP5Security/tests/testERP5Security.py

@@ -30,6 +30,7 @@
 """Tests ERP5 User Management.
 """
 
+import transaction
 import unittest
 from Products.ERP5Type.tests.ERP5TypeTestCase import ERP5TypeTestCase
 from Products.ERP5Type.tests.utils import createZODBPythonScript
@@ -53,6 +54,7 @@ class TestUserManagement(ERP5TypeTestCase):
 
   def beforeTearDown(self):
     """Clears person module and invalidate caches when tests are finished."""
+    transaction.abort()
     self.getPersonModule().manage_delObjects([x for x in
                              self.getPersonModule().objectIds()])
     self.tic()
@@ -392,6 +394,17 @@ class TestUserManagement(ERP5TypeTestCase):
     self._assertUserDoesNotExists('the_user', 'secret')
     self._assertUserExists('the_user', 'secret2')
 
+  def test_ERP5LoginUserManagerMigration(self):
+    acl_users= self.portal.acl_users
+    acl_users.manage_delObjects(ids=['erp5_login_users'])
+    portal_templates = self.portal.portal_templates
+    self.assertNotEqual(portal_templates.checkConsistency(filter={'constraint_type': 'post_upgrade'}) , [])
+    # call checkConsistency again to check if FIX does not happen by checkConsistency().
+    self.assertNotEqual(portal_templates.checkConsistency(filter={'constraint_type': 'post_upgrade'}) , [])
+    portal_templates.fixConsistency(filter={'constraint_type': 'post_upgrade'})
+    self.assertEqual(portal_templates.checkConsistency(filter={'constraint_type': 'post_upgrade'}) , [])
+    self.assertTrue('erp5_login_users' in acl_users)
+
   def test_AssignmentWithDate(self):
     """Tests a person with an assignment with correct date is a valid user."""
     date = DateTime()