fixup: ERP5TypeFunctionalTestCase: support running tests on seleniumserver

See romain/erp5@f10cc273

product/ERP5Type/tests/ERP5TypeFunctionalTestCase.py

@@ -242,7 +242,7 @@ class FunctionalTestRunner:
       selenium_test_runner_configuration = test_runner_configuration.get('selenium', {})
       use_local_firefox = selenium_test_runner_configuration.get('server-url') is None
       if 'firefox' not in selenium_test_runner_configuration.get(
-          'desired-capabilities', {}).get('browserName').lower():
+          'desired-capabilities', {}).get('browserName', '').lower():
         options = None
 
     if use_local_firefox:

[Jérome Perrin]

oops thanks. I don't understand why tests were running before this fix. Maybe it broke only when slapos master was merged in slapos 1.0 ?

[Romain Courteaud]

It seems service worker are not available with the latest changes, and this leads to most errors. I didn't check yet if the firefox version changed. Do you have any idea?

[Jérome Perrin]

Firefox version should not have changed. I was trying slapos!1003 (merged) but this does not change the default firefox used by testnodes either ... and it's not supposed to change unless we update testnode, the firefox version comes from

software-path-list = ["https://lab.nexedi.com/nexedi/slapos/raw/1.0.181/software/seleniumrunner/software.cfg"]

line from https://lab.nexedi.com/nexedi/slapos/raw/1.0.182/software/erp5testnode/instance-default.cfg

is it really that everything using service worker stopped working ?

[Jérome Perrin]

in https://erp5js.nexedi.net/#/test_result_module/20210630-68486DBA/187 we have:

selenium.browserbot.currentWindow.navigator.serviceWorker is undefined (HTML)

this seems new. This must be because this

    options.set_preference('dom.serviceWorkers.enabled', True)

from https://lab.nexedi.com/nexedi/erp5/blob/17e1c26244724206cf0cad49dfd04d33a82c0e0f/product/ERP5Type/tests/ERP5TypeFunctionalTestCase.py#L233 no longer work.

[Jérome Perrin]

I guess the problem is that this if

     if 'firefox' not in selenium_test_runner_configuration.get(
          'desired-capabilities', {}).get('browserName', '').lower():
        options = None

becomes true. The initial intention was to set options = None for the case where we are not using firefox, but this evaluates to true also for the default value. I think we can change this if, I'm trying a patch on for_testrunner_1 (in a few seconds)

[Jérome Perrin]

Let's try ee411a73

[Romain Courteaud]

It seems all good 👍

[Jérome Perrin]

Thanks yes, it seems good enough, I'm pushing this commit in master, thanks !