Commit 2222bd5a authored by Kazuhiko Shiozaki's avatar Kazuhiko Shiozaki

add more comments on current issues.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@36522 20353a03-c40f-0410-a6d1-a30d3c3de9de
parent 0fa60d0e
...@@ -83,6 +83,8 @@ class SolverProcessTool(BaseTool): ...@@ -83,6 +83,8 @@ class SolverProcessTool(BaseTool):
or a list thereof or a list thereof
""" """
# Do not create a new solver process if no divergence # Do not create a new solver process if no divergence
# XXX (possible performance issue) Here it calls all divergence
# testers, but they should be called later.
if not self.isDivergent(delivery_or_movement=delivery_or_movement): if not self.isDivergent(delivery_or_movement=delivery_or_movement):
return None return None
...@@ -93,10 +95,13 @@ class SolverProcessTool(BaseTool): ...@@ -93,10 +95,13 @@ class SolverProcessTool(BaseTool):
new_solver.buildSolverDecisionList(delivery_or_movement=delivery_or_movement, new_solver.buildSolverDecisionList(delivery_or_movement=delivery_or_movement,
temp_object=temp_object) temp_object=temp_object)
# Append the solver process into the delivery's solver category if not temp_object:
delivery = delivery_or_movement.getRootDeliveryValue() # Append the solver process into the delivery's solver category
solver_list = delivery.getSolverValueList() # XXX using delivery's solver category is not so good idea,
solver_list.append(new_solver) # because we might want to solve several deliveries with one
delivery.setSolverValueList(solver_list) # solver process, several users want to solve one document etc.
return new_solver delivery = delivery_or_movement.getRootDeliveryValue()
solver_list = delivery.getSolverValueList()
solver_list.append(new_solver)
delivery.setSolverValueList(solver_list)
return new_solver
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment