ZODB Components: Preparation of erp5_base migration from FS: Fix pylint...

ZODB Components: Preparation of erp5_base migration from FS: Fix pylint unbalanced-tuple-unpacking warning.

product/ERP5/mixin/builder.py

@@ -477,7 +477,7 @@ class BuilderMixin(XMLObject, Amount, Predicate):
         not self._isUpdated(x, 'delivery')]
       if merge_delivery:
         # We must have only one delivery to update in the case of merge
-        delivery, = delivery_to_update_list
+        delivery = delivery_to_update_list[0]
         property_dict = {}
       else:
         delivery, property_dict = self._findUpdatableObject(

[Jérome Perrin]

We often do this on purpose so that it fails when there is more than one element in the list, especially in tests.

How about adding a assert len(delivery_to_update_list) == 1 or something ?

[Arnaud Fontaine]

I didn't know about that. I will commit your suggestion tomorrow unless somebody has a better idea. Thanks!

[Jérome Perrin]

This is maybe a case where a line comment to disable the pylint check is acceptable.

delivery, = delivery_to_update_list #pylint: disable=unbalanced-tuple-unpacking

[Arnaud Fontaine]

Well, having an assert or something similar makes it clear that there must be only one element, whereas pylint disabling comment does not IMO.