Test applying model.

bt5/erp5_computer_immobilisation/TestTemplateItem/testERP5ComputerWithComputerModel.py

+# Copyright (c) 2012 Nexedi SA and Contributors. All Rights Reserved.
+import unittest
+from Products.ERP5Type.tests.ERP5TypeTestCase import ERP5TypeTestCase
+
+class TestERP5ComputerWithComputerModel(ERP5TypeTestCase):
+
+  def getBusinessTemplateList(self):
+    return [ 'erp5_base', 'erp5_computer_immobilisation' ]
+
+  def afterSetUp(self):
+    pass
+
+  def beforeTearDown(self):
+    pass
+
+  def newModel(self, **kw):
+    return self.portal.computer_model_module.newContent(
+      portal_type='Computer Model', **kw)
+
+  def newComputer(self, **kw):
+    return self.portal.computer_module.newContent(
+      portal_type='Computer', **kw)
+
+  def test_apply_model_empty_computer(self):
+    category_list = ['mana', 'mahna']
+    model = self.newModel(group=category_list)
+    computer = self.newComputer(specialise_value=model)
+    self.assertEqual(computer.getPropertyList('group'), [])
+    result = computer.Computer_applyComputerModel()
+    self.assertEqual(computer.getPropertyList('group'), category_list)
+    self.assertTrue('=Computer%20Model%20applied.' in result, result)
+
+  def test_apply_model_empty_computer_batch_mode(self):
+    category_list = ['mana', 'mahna']
+    model = self.newModel(group=category_list)
+    computer = self.newComputer(specialise_value=model)
+    self.assertEqual(computer.getPropertyList('group'), [])
+    result = computer.Computer_applyComputerModel(batch_mode=1)
+    self.assertEqual(computer.getPropertyList('group'), category_list)
+    self.assertTrue(result)
+
+  def test_apply_model_filled_computer(self):
+    computer_category_list = ['oink']
+    category_list = ['mana', 'mahna']
+    model = self.newModel(group=category_list)
+    computer = self.newComputer(specialise_value=model,
+      group=computer_category_list)
+    self.assertEqual(computer.getPropertyList('group'),
+      computer_category_list)
+    result = computer.Computer_applyComputerModel()
+    self.assertEqual(computer.getPropertyList('group'),
+      computer_category_list)
+    self.assertTrue('=No%20changes%20applied.' in result, result)
+
+  def test_apply_model_filled_computer_batch_mode(self):
+    computer_category_list = ['oink']
+    category_list = ['mana', 'mahna']
+    model = self.newModel(group=category_list)
+    computer = self.newComputer(specialise_value=model,
+      group=computer_category_list)
+    self.assertEqual(computer.getPropertyList('group'),
+      computer_category_list)
+    result = computer.Computer_applyComputerModel()
+    self.assertEqual(computer.getPropertyList('group'),
+      computer_category_list)
+    self.assertTrue(result)
+
+  def test_apply_model_filled_computer_forced(self):
+    computer_category_list = ['oink']
+    category_list = ['mana', 'mahna']
+    model = self.newModel(group=category_list)
+    computer = self.newComputer(specialise_value=model,
+      group=computer_category_list)
+    self.assertEqual(computer.getPropertyList('group'),
+      computer_category_list)
+    result = computer.Computer_applyComputerModel(force=1)
+    self.assertEqual(computer.getPropertyList('group'),
+      category_list)
+    self.assertTrue('=Computer%20Model%20applied.' in result, result)
+
+  def test_apply_model_filled_computer_force_batch_mode(self):
+    computer_category_list = ['oink']
+    category_list = ['mana', 'mahna']
+    model = self.newModel(group=category_list)
+    computer = self.newComputer(specialise_value=model,
+      group=computer_category_list)
+    self.assertEqual(computer.getPropertyList('group'),
+      computer_category_list)
+    result = computer.Computer_applyComputerModel(force=1, batch_mode=1)
+    self.assertEqual(computer.getPropertyList('group'),
+      category_list)
+    self.assertTrue(result)
+
+  def test_apply_no_model(self):
+    computer = self.newComputer()
+    result = computer.Computer_applyComputerModel()
+    self.assertTrue('=No%20Computer%20Model.' in result, result)
+
+  def test_apply_no_model_batch_mode(self):
+    computer = self.newComputer()
+    result = computer.Computer_applyComputerModel(batch_mode=1)
+    self.assertEqual(False, result)
+
+  def test_category_coverage(self):
+    category_dict = {
+      'allocation_scope': ['allocation_scope1', 'allocation_scope2'],
+      'cpu_core': ['cpu_core1', 'cpu_core2'],
+      'cpu_frequency': ['cpu_frequency1', 'cpu_frequency2'],
+      'cpu_type': ['cpu_type1', 'cpu_type2'],
+      'function': ['function1', 'function2'],
+      'group': ['group1', 'group2'],
+      'local_area_network_type': ['local_area_network_type1',
+        'local_area_network_type2'],
+      'memory_size': ['memory_size1', 'memory_size2'],
+      'memory_type': ['memory_type1', 'memory_type2'],
+      'product_line': ['product_line1', 'product_line2'],
+      'role': ['role1', 'role2'],
+      'storage_capacity': ['storage_capacity1', 'storage_capacity2'],
+      'storage_interface': ['storage_interface1', 'storage_interface2'],
+      'storage_redundancy': ['storage_redundancy1', 'storage_redundancy2'],
+    }
+    model = self.newModel(**category_dict)
+
+    category_list = []
+    for k, v in category_dict.iteritems():
+      for l in v:
+        category_list.append('%s/%s' % (k,l))
+    category_list.append('specialise/%s' % model.getRelativeUrl())
+    computer = self.newComputer(specialise_value=model)
+    result = computer.Computer_applyComputerModel()
+    self.assertSameSet(category_list, computer.getCategoryList())
+    self.assertTrue('=Computer%20Model%20applied.', result)
+
+def test_suite():
+  suite = unittest.TestSuite()
+  suite.addTest(unittest.makeSuite(TestERP5ComputerWithComputerModel))
+  return suite

bt5/erp5_computer_immobilisation/bt/revision

-46
+47
\ No newline at end of file

bt5/erp5_computer_immobilisation/bt/template_test_id_list

+testERP5ComputerWithComputerModel
\ No newline at end of file

[Georgios Dagkakis]

@luke I think that this should have batch_mode=1, right? All other test_xxx_batch_mode here work like this. Yet, if I change with it, the self.assertTrue(result) below fails, so it seems to me like a bug or at least unexpected behaviour hidden by the test?

But I really do not know this code, I just noticed doing a generic, unrelated, change

[Łukasz Nowak]

Hm, from tip of my head I can't tell. @rafael may have more insight about how shall it work, then I can fix it.

[Georgios Dagkakis]

FWIW, without batch_mode=True passed, then Computer_applyComputerModel would return Base_redirect, so self.assertTrue(result) is really checking nothing useful here.

But now I think the correct for this test would be:

    result = computer.Computer_applyComputerModel(batch_mode=True)
    ...
    self.assertFalse(result)

since 'sister' test test_apply_model_filled_computer expects No%20changes%20applied in portal_status_message, and in that case in batch_mode we have result = False.

So, now that I checked more carefully it seems that it is no bug, but test does need update. I can update if no objection by you or @rafael

[Łukasz Nowak]

+1 for me, thank you.

[Georgios Dagkakis]

pushed in bb8474bf