core/gadget_global.js: make isEmpty supports empty object

Co-authored-by: Romain Courteaud <romain@nexedi.com>

product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/gadget_global.js.js

@@ -9,10 +9,14 @@
   Calling isEmpty(x) is more robust than expression !x.
   */
   function isEmpty(value) {
-    return (value === undefined ||
-            value === null ||
-            value.length === 0 ||
-            (typeof value === "number" && isNaN(value)));
+    return (
+      (value === undefined) ||
+      (value === null) ||
+      ((typeof value === "number") ?
+        isNaN(value) :
+        (Object.keys(value).length === 0)
+      )
+    );
   }
   window.isEmpty = isEmpty;
 

[Romain Courteaud]

@jerome I spotted a regression, as the new isEmpty implementation consider any boolean as empty. See romain/erp5@a47b421b

[Jérome Perrin]

oh you are right, sorry. romain/erp5@a47b421b seems good.