Added Base_viewWorkflowActionDialog which will someday replace...

Added Base_viewWorkflowActionDialog which will someday replace BaseWorkflow_viewWorkflowActionDialog ( bad naming ).
Please update your workflow transisitons.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@15565 20353a03-c40f-0410-a6d1-a30d3c3de9de

product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Base_viewWorkflowActionDialog.xml

+<?xml version="1.0"?>
+<ZopeData>
+  <record id="1" aka="AAAAAAAAAAE=">
+    <pickle>
+      <tuple>
+        <tuple>
+          <string>Products.ERP5Form.Form</string>
+          <string>ERP5Form</string>
+        </tuple>
+        <none/>
+      </tuple>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>__ac_local_roles__</string> </key>
+            <value>
+              <none/>
+            </value>
+        </item>
+        <item>
+            <key> <string>_bind_names</string> </key>
+            <value>
+              <object>
+                <klass>
+                  <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
+                </klass>
+                <tuple/>
+                <state>
+                  <dictionary>
+                    <item>
+                        <key> <string>_asgns</string> </key>
+                        <value>
+                          <dictionary/>
+                        </value>
+                    </item>
+                  </dictionary>
+                </state>
+              </object>
+            </value>
+        </item>
+        <item>
+            <key> <string>_objects</string> </key>
+            <value>
+              <tuple/>
+            </value>
+        </item>
+        <item>
+            <key> <string>action</string> </key>
+            <value> <string>Workflow_statusModify</string> </value>
+        </item>
+        <item>
+            <key> <string>encoding</string> </key>
+            <value> <string>UTF-8</string> </value>
+        </item>
+        <item>
+            <key> <string>enctype</string> </key>
+            <value> <string></string> </value>
+        </item>
+        <item>
+            <key> <string>group_list</string> </key>
+            <value>
+              <list>
+                <string>left</string>
+              </list>
+            </value>
+        </item>
+        <item>
+            <key> <string>groups</string> </key>
+            <value>
+              <dictionary>
+                <item>
+                    <key> <string>left</string> </key>
+                    <value>
+                      <list>
+                        <string>my_comment</string>
+                        <string>my_workflow_action</string>
+                      </list>
+                    </value>
+                </item>
+              </dictionary>
+            </value>
+        </item>
+        <item>
+            <key> <string>id</string> </key>
+            <value> <string>Base_viewWorkflowActionDialog</string> </value>
+        </item>
+        <item>
+            <key> <string>method</string> </key>
+            <value> <string>POST</string> </value>
+        </item>
+        <item>
+            <key> <string>name</string> </key>
+            <value> <string>Base_viewWorkflowActionDialog</string> </value>
+        </item>
+        <item>
+            <key> <string>pt</string> </key>
+            <value> <string>form_view_dialog</string> </value>
+        </item>
+        <item>
+            <key> <string>row_length</string> </key>
+            <value> <int>4</int> </value>
+        </item>
+        <item>
+            <key> <string>stored_encoding</string> </key>
+            <value> <string>UTF-8</string> </value>
+        </item>
+        <item>
+            <key> <string>title</string> </key>
+            <value> <string>Validate Workflow Action</string> </value>
+        </item>
+        <item>
+            <key> <string>uid</string> </key>
+            <value>
+              <none/>
+            </value>
+        </item>
+        <item>
+            <key> <string>unicode_mode</string> </key>
+            <value> <int>0</int> </value>
+        </item>
+        <item>
+            <key> <string>update_action</string> </key>
+            <value> <string></string> </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+</ZopeData>

product/ERP5/bootstrap/erp5_core/bt/revision

-384
+385
\ No newline at end of file

[Georgios Dagkakis]

@jerome seems someday is still waiting to come :). Noticed this, since it cause some bug in new UI mass workflow transition, coming from <a='https://lab.nexedi.com/nexedi/erp5/blob/master/product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Folder_modifyDocumentListStatus.py#L25'>here.

So, question, if one does a blind replace of BaseWorkflow_viewWorkflowActionDialog?workflow_action with Base_viewWorkflowActionDialog?workflow_action in filesystem, do you think it would be good enough? Then we require projects to do and (maybe?) we remove BaseWorkflow_viewWorkflowActionDialogaltogether?

[Jérome Perrin]

I guess we can replace BaseWorkflow_viewWorkflowActionDialogaltogether by Base_viewWorkflowActionDialogaltogether everywhere, but if the new UI cannot render other workflow dialog forms than Base_viewWorkflowActionDialog, then it's a problem.

One important feature is to be able to use a custom workflow dialog on a selection of documents, for example "post a reply and close the ticket" on ticket workflow where there's a editor field to post a reply.

This is supposed to be tested in testFolderWorkflowActionCustomDialog.

I have not followed the port of mass workflow transition to new UI, I'm not sure what's the current state. Maybe @romain can confirm if this is supposed to work already ?

[Jérome Perrin]

( I think I should cc @georgios.dagkakis explicitely for my reply because this commit is not in a MR )

[Romain Courteaud]

@jerome @georgios.dagkakis Mass workflow transition in new UI has a completely different implementation and behaviour. This was required because selections are not used in the new UI. The dialog support custom dialog normally. The "only" hardcoded part is to handle the actbox_url query parameter which is for now manually set in the request.

This code expects the hidden your_workflow_action, but BaseWorkflow_viewWorkflowActionDialog uses my_workflow_action. I'll workaround this for now by adding another hardcoded value...