Commit aaf79d2b authored by Jérome Perrin's avatar Jérome Perrin Committed by Aurel

oauth_facebook_login: update # hack to be compatible with Zope4 redirects

Zope4 uses urlparse + urlunparse to encode the URL, which has a side
effect of removing the empty fragment from the URL. Using a lower level
API to set the status code and the Location header we achieve the same
result.
parent e3db3e62
...@@ -49,6 +49,10 @@ elif code is not None: ...@@ -49,6 +49,10 @@ elif code is not None:
# https://stackoverflow.com/questions/7131909/facebook-callback-appends-to-return-url/33257076#33257076 # https://stackoverflow.com/questions/7131909/facebook-callback-appends-to-return-url/33257076#33257076
# https://lab.nexedi.com/nexedi/erp5/merge_requests/417#note_64365 # https://lab.nexedi.com/nexedi/erp5/merge_requests/417#note_64365
came_from = request.get("came_from", portal.absolute_url() + "#") came_from = request.get("came_from", portal.absolute_url() + "#")
return response.redirect(came_from) # Don't use response.redirect, as it normalize the URL (in Zope4) and remove the
# empty fragment - which is an equivalent URL, but for this special case we want to keep the #
response.setStatus(302, lock=True)
response.setHeader('Location', came_from)
return came_from
return handleError('') return handleError('')
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment