Commit bda6bc3c authored by Yoshinori Okuji's avatar Yoshinori Okuji

Add missing self. Stop calling needlessly iterkeys.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@28833 20353a03-c40f-0410-a6d1-a30d3c3de9de
parent 9275c91f
...@@ -216,7 +216,7 @@ class SimulationMovement(Movement): ...@@ -216,7 +216,7 @@ class SimulationMovement(Movement):
""" """
Returns 1 if this needs to be ordered Returns 1 if this needs to be ordered
""" """
if isOrderable(): if self.isOrderable():
return len(self.getCategoryMembership('order')) is 0 return len(self.getCategoryMembership('order')) is 0
else: else:
return 0 return 0
...@@ -227,7 +227,7 @@ class SimulationMovement(Movement): ...@@ -227,7 +227,7 @@ class SimulationMovement(Movement):
""" """
Returns 1 if this needs to be accounted Returns 1 if this needs to be accounted
""" """
if isDeliverable(): if self.isDeliverable():
return len(self.getCategoryMembership('delivery')) is 0 return len(self.getCategoryMembership('delivery')) is 0
else: else:
return 0 return 0
...@@ -263,7 +263,7 @@ class SimulationMovement(Movement): ...@@ -263,7 +263,7 @@ class SimulationMovement(Movement):
for rule in portal_rules.searchRuleList(self, sort_on='version', for rule in portal_rules.searchRuleList(self, sort_on='version',
sort_order='descending'): sort_order='descending'):
ref = rule.getReference() ref = rule.getReference()
if ref and ref not in applicable_rule_dict.iterkeys(): if ref and ref not in applicable_rule_dict:
applicable_rule_dict[ref] = rule applicable_rule_dict[ref] = rule
for applied_rule in self.objectValues(): for applied_rule in self.objectValues():
...@@ -275,7 +275,7 @@ class SimulationMovement(Movement): ...@@ -275,7 +275,7 @@ class SimulationMovement(Movement):
for rule in applicable_rule_dict.itervalues(): for rule in applicable_rule_dict.itervalues():
rule_type = rule.getPortalType() rule_type = rule.getPortalType()
if rule_type not in applied_rule_dict.iterkeys(): if rule_type not in applied_rule_dict:
applied_rule = rule.constructNewAppliedRule(self, **kw) applied_rule = rule.constructNewAppliedRule(self, **kw)
applied_rule_dict[rule_type] = applied_rule applied_rule_dict[rule_type] = applied_rule
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment