Commit c1d27830 authored by Jérome Perrin's avatar Jérome Perrin

officejs_afs_directory: support empty wikipedia URL

This was causing several requests to
https://en.wikipedia.org/api/rest_v1/page/summary/ without a page name,
which are 404 error pages.
parent 7597a09d
......@@ -56,7 +56,7 @@
} else {
software.success_case_list = clean(software.success_case_list);
}
if (software.wikipedia_url === "N/A") {
if (software.wikipedia_url === "N/A" || software.wikipedia_url === "") {
delete software.wikipedia_url;
} else {
wiki_list.push(
......
......@@ -246,8 +246,8 @@
</tuple>
<state>
<tuple>
<float>1496067089.61</float>
<string>UTC</string>
<float>1568109300.4</float>
<string>GMT+9</string>
</tuple>
</state>
</object>
......
  • /cc @frequent this is to try to fix this test failing sometimes ( for example this time )

    I noticed that the test makes several requests to https://en.wikipedia.org/api/rest_v1/page/summary/ , they seem to be slow sometimes . I'm not really convinced it can be the cause of the failures, but it seems better not to make these requests since they 404 .

  • @jerome - I fixed this. @romain - did you already commit my changes ?

  • oh sorry for noise, this MR ( !922 (merged) ) was on a quite old branch. With eb39ffef it's no longer needed.

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment