test_result: pylint py3

bt5/erp5_test_result/DocumentTemplateItem/portal_components/document.erp5.CloudPerformanceUnitTestDistributor.py

@@ -42,7 +42,6 @@ class CloudPerformanceUnitTestDistributor(ERP5ProjectUnitTestDistributor):
     all test nodes runs all test suites, this is not a problem to keep
     configuration
     """
-    pass
 
   security.declarePublic("optimizeConfiguration")
   def optimizeConfiguration(self):

bt5/erp5_test_result/DocumentTemplateItem/portal_components/document.erp5.TestSuite.py

@@ -68,15 +68,15 @@ class TestSuite(XMLObject, PeriodicityMixin):
   # setting of some properties that were defined with type "lines" instead of "string".
   # This was making the property existence constraint not working properly.
   def _fixPropertyConsistency(self):
-    self = aq_base(self)
+    aq_base_self = aq_base(self)
     for property_name in ('additional_bt5_repository_id', 'test_suite'):
-      property_value = getattr(self, property_name, None)
+      property_value = getattr(aq_base_self, property_name, None)
       if property_value is not None and isinstance(property_value, tuple):
         if len(property_value) > 0:
           property_value = property_value[0]
-          setattr(self, property_name, property_value)
+          setattr(aq_base_self, property_name, property_value)
         else:
-          delattr(self, property_name)
+          delattr(aq_base_self, property_name)
 
   def getAdditionalBt5RepositoryId(self, *args, **kw):
     self._fixPropertyConsistency()

bt5/erp5_test_result/DocumentTemplateItem/portal_components/document.erp5.TestSuiteRepository.py

@@ -13,15 +13,15 @@ class TestSuiteRepository(XMLObject):
   # setting of some properties that were defined with type "lines" instead of "string".
   # This was making the property existence constraint not working properly.
   def _fixPropertyConsistency(self):
-    self = aq_base(self)
+    aq_base_self = aq_base(self)
     for property_name in ('branch', 'buildout_section_id', 'git_url', 'profile_path'):
-      property_value = getattr(self, property_name, None)
+      property_value = getattr(aq_base_self, property_name, None)
       if property_value is not None and isinstance(property_value, tuple):
         if len(property_value) > 0:
           property_value = property_value[0]
-          setattr(self, property_name, property_value)
+          setattr(aq_base_self, property_name, property_value)
         else:
-          delattr(self, property_name)
+          delattr(aq_base_self, property_name)
 
   def getBranch(self, *args, **kw):
     self._fixPropertyConsistency()

bt5/erp5_test_result/ExtensionTemplateItem/portal_components/extension.erp5.TestResults.py

@@ -301,7 +301,7 @@ def TestResult_sendEmailNotification(self, mail_to=None, mail_from=None,
                     " %s lines" % max_line_count)
       traceback_attachment[max_line_count:] = '', '', '(truncated) ...'
     content = '\n'.join(traceback_attachment)
-    if isinstance(content, unicode):
+    if not isinstance(content, bytes):
       content = content.encode('utf8')
     attachment_list.append(dict(name='traceback.txt',
                                 mime_type='text/plain',