PropertySheetChild is not an acceptable prefix, use Base as the context
is used. Technically, this uses the "id as reference" mixin, but this
mixin is a bit special as it has takes the suffix as parameter and does
not reside in mixin module, so we just use Base as a prefix.

FieldValidator is not an acceptable prefix,
Base_validateDialogConfirmation seems better

Rounding scripts:

Planning is not an acceptable prefix, this script is called on the
current context, so let's use Base_ as a prefix.

Planning_roundBoundToMinute → Base_roundPlanningBoxBoundToMinute
Planning_roundBoundToDay → Base_roundPlanningBoxBoundToDay
Planning_roundBoundToInt → Base_roundPlanningBoxBoundToInt

Module is an acceptable prefix for modules

Introduce a list of skins IDs that does not match our conventions but
are acceptable because this is what external API are calling.

Some portal types such as Business Template were not tested by testXHTML
because this tests starts by modules and recursively tests based on
allowed content types. But types that are not created in a module but in
a tool were never tested.

Keep the current way of testing view of portal types in their natural
containers by starting from modules and make another pass to test anyway
portal types that might be contained in tool. In that case, we use a
mapping of known tools IDs because I don't think we can introspect at
this point.

We want this check to run on all components.

Without this, subclassing defining this method will have rguments-differ
pylint warning because the signature of Base._checkConsistency is
different.

This `o` was an unused variable. The initial intention was probably
this.

This will allow to find problems when only business templates and their
dependencies are installed. When we run testXHTML with all business
template installed we don't see problems that may happen only when some
business templates are not installed.

These scripts are used to check the site configuration and also in
CodingStyleTest.

This is just the minimal so taht CodingStyleTest can run, but this could
be extended to several scripts currently in erp5_toolbox skinfolder of
erp5_forge which overlaps with erp5_administration.

- tests updated

- test extended

If automatic GC happens just after the testnode repository is updated,
the repository in the SR may lose objects and fail to update.

See commit 9634a7d8.

Pylint warnings are now causing test failures.

/reviewed-on !987

revision(s) a Test Result has already been completed.
Thus we need to properly handle this use case otherwise simply failing makes "client
side" - i.e. testnode keep trying forever in its _retryRPC calls which
indefinitely blocks further tests executions.

We'll gradually enable the business templates as we fix them.

We have testERP5NamingConvention.py for this purpose.

 - Use TypesTool methods instead of looking in modules __dict__ when
   possible.
 - Allow prefixes from mixin
 - Allow prefixes from interfaces without the I ( ISomething ->
   Something )
 - Allow "Zuite" and "ListBox" that are used in zelenium tests.
 - Allow "DCWorkflow" that is used in some workflow scripts.

PortalTransforms: safe_html: Changes in b255c894 were not actually applied so merge FS module and portal_transforms/safe_html.

These titles duplicate listbox configuration, preventing any change from
reaching users (...who customised their listbox).
Also fixes cases where column title was stored in selection after
translation, which breaks some reports.

Avoid double-calls when one is enough.
Avoid unused locals.
Avoid repeating conditions.
Inline single-use expressions.

Bootstrap is actually the automatic migration of tools. It happened to me
several times that I mistakenly start an old instance on a too new version of
products and this instance is migrated automatically.

By leaving a note in transaction it's easier to find out which
transaction performed the automatic migration to revert to the state
before using technique such as
https://blog.gocept.com/2019/06/14/undo-transactions-by-truncating-zodb-data-fs/
for FileStorage.

with this change, a command such as;

    python -m ZODB.scripts.fstail -n 20 ./instance/slappart6/srv/zodb/root.fs

show something like:

    2019-11-12 02:46:42.106313: hash=44fecb9a63411fbf305cea82f4c699c478000d61
    user=' None' description='/timer_service/process_timer\nSite migrated' length=462938 offset=881877846 (+70)

for the transaction which did the migration, so it's easy to repair.

/reviewed-on nexedi/erp5!975