1. 27 Nov, 2019 24 commits
    • Jérome Perrin's avatar
      ingestion: split erp5_ingestion in erp5_ingestion_test · 55b75d36
      Jérome Perrin authored
      erp5_ingestion contained a skin folder for tests, with some proxy fields depending on erp5_web.
      There was a proper test dependency to erp5_web, but in static analysis check we now check the skin folders, so it's no longer allowed to have some skin folder that are broken without test dependencies but not supposed to be used outside of tests.
      55b75d36
    • Jérome Perrin's avatar
      hr: fix proxy fields · 3899b2bf
      Jérome Perrin authored
      Since this was using proxy fields from erp5_crm, add dependency on CRM.
      Update to the new name of CRM field library.
      3899b2bf
    • Jérome Perrin's avatar
      video: fix <video> editor field · 4eb40207
      Jérome Perrin authored
      nuvalidator complains that:
        Bad value “true” for attribute “autoplay” on element “video”
      
      This could probably be switched to VideoField now.
      4eb40207
    • Jérome Perrin's avatar
      VideoField: make valid HTML5 regarding preload · d1ab1ad9
      Jérome Perrin authored
      Unlike other attributes managed in video field, preload [1] is not a
      boolean attribute, so setting preload="preload" was invalid HTML5.
      
      On the field, we can only configure video_preload as a boolean
      attribute, setting preload="auto" when true and not setting preload when
      False seems the closest meaning of True/False.
      
      [1] https://html.spec.whatwg.org/multipage/media.html#attr-media-preload
      d1ab1ad9
    • Jérome Perrin's avatar
      tiosafe_core: depend on erp5_accounting · 36ecfe16
      Jérome Perrin authored
      IntegrationSite_view/my_source_payment is a proxyfield to a field in
      erp5_accounting.
      36ecfe16
    • Jérome Perrin's avatar
      post: depend on crm · 2501a65d
      Jérome Perrin authored
      It uses proxy fields from erp5_crm
      2501a65d
    • Jérome Perrin's avatar
      project_ui: fix duplicate selection names · aeac620c
      Jérome Perrin authored
         'base_view_document_selection'
      	'Base_viewDocumentList/listbox': set(['erp5_core'])
      	'Project_viewDocumentList/listbox': set(['erp5_web_project'])
         'project_module_selection'
      	'ProjectModule_viewProjectList/listbox': set(['erp5_project'])
      	'ProjectModule_viewProjectManagementList/listbox': set(['erp5_web_project'])
      aeac620c
    • Jérome Perrin's avatar
      officejs: fix duplicate selection names · a8dfe92c
      Jérome Perrin authored
      These selection names were already used in other business templates:
      
         'web_page_module_view_web_page_list_selection'
      	'WebPageModule_viewWebPageListAsJioForCodemirror/listbox': set(['erp5_officejs_codemirror'])
      	'WebPageModule_viewWebPageListAsJioForTextEditor/listbox': set(['erp5_text_editor'])
      	'WebPageModule_viewWebPageList/listbox': set(['erp5_web'])
      	'DocumentModule_viewDocumentListAsJioForPdfViewer/listbox': set(['erp5_officejs_pdf_viewer'])
         'image_selection'
      	'WebPageModule_viewWebPageListAsJioForSvgEditor/listbox': set(['erp5_officejs_svg_editor'])
      	'ImageModule_viewImageList/listbox': set(['erp5_dms'])
      a8dfe92c
    • Jérome Perrin's avatar
      core: rename PropertySheetChild_validateIDField · 9b36710c
      Jérome Perrin authored
      PropertySheetChild is not an acceptable prefix, use Base as the context
      is used. Technically, this uses the "id as reference" mixin, but this
      mixin is a bit special as it has takes the suffix as parameter and does
      not reside in mixin module, so we just use Base as a prefix.
      9b36710c
    • Jérome Perrin's avatar
      bt5: fix naming convention for FieldValidator_requireIfDialogConfirmed · 77a2301b
      Jérome Perrin authored
      FieldValidator is not an acceptable prefix,
      Base_validateDialogConfirmation seems better
      77a2301b
    • Jérome Perrin's avatar
      bt5: rename planning box scripts to comply with naming conventions · 4a57ff53
      Jérome Perrin authored
      Rounding scripts:
      
      Planning is not an acceptable prefix, this script is called on the
      current context, so let's use Base_ as a prefix.
      
      Planning_roundBoundToMinute → Base_roundPlanningBoxBoundToMinute
      Planning_roundBoundToDay → Base_roundPlanningBoxBoundToDay
      Planning_roundBoundToInt → Base_roundPlanningBoxBoundToInt
      4a57ff53
    • Jérome Perrin's avatar
      CodingStyle: ignore more skins and prefixs · b5b2e2d0
      Jérome Perrin authored
      Module is an acceptable prefix for modules
      
      Introduce a list of skins IDs that does not match our conventions but
      are acceptable because this is what external API are calling.
      b5b2e2d0
    • Jérome Perrin's avatar
      core: fix Folder_cut to check relations of sub-objects · 74add66d
      Jérome Perrin authored
      This `o` was an unused variable. The initial intention was probably
      this.
      74add66d
    • Jérome Perrin's avatar
      core: remove unused scripts · 2eaa22f9
      Jérome Perrin authored
      These scripts are not used and does not respect naming conventions or
      have pylint errors.
      2eaa22f9
    • Jérome Perrin's avatar
      core: trivial fixes for pylint · 268a0884
      Jérome Perrin authored
      268a0884
    • Jérome Perrin's avatar
      CodingStyleTest: run testXHTML for each business template · 85cb1131
      Jérome Perrin authored
      This will allow to find problems when only business templates and their
      dependencies are installed. When we run testXHTML with all business
      template installed we don't see problems that may happen only when some
      business templates are not installed.
      85cb1131
    • Jérome Perrin's avatar
      forge/administration: move some scripts to administration · fb693787
      Jérome Perrin authored
      These scripts are used to check the site configuration and also in
      CodingStyleTest.
      
      This is just the minimal so that CodingStyleTest can run, but this could
      be extended to several scripts currently in erp5_toolbox skinfolder of
      erp5_forge which overlaps with erp5_administration. Also, regarding
      CodingStyleTest, it seems that erp5_administration contain a lot of
      things, so we may want to extract a smaller business template containing
      only the scripts used for static analysis of business template.
      fb693787
    • Jérome Perrin's avatar
      administration: include new component types in "check source code" · 0bb3efc6
      Jérome Perrin authored
      We want this check to run on all components.
      0bb3efc6
    • Jérome Perrin's avatar
      testXHTML: test portal types also from tools · 8f47b8bc
      Jérome Perrin authored
      Some portal types such as Business Template were not tested by testXHTML
      because this tests starts by modules and recursively tests based on
      allowed content types. But types that are not created in a module but in
      a tool were never tested.
      
      Keep the current way of testing view of portal types in their natural
      containers by starting from modules and make another pass to test anyway
      portal types that might be contained in tool. In that case, we use a
      mapping of known tools IDs because I don't think we can introspect at
      this point.
      8f47b8bc
    • Jérome Perrin's avatar
      core: support non initialized cache when viewing cache statistics · ffd78ee1
      Jérome Perrin authored
      Maybe what's missing is an interaction to update cache internals with
      updateCache when a cache is added, but that's enough to make TestXHTML
      pass now.
      
      fixup! core: workaround non initialized cache when viewing cache statistics
      ffd78ee1
    • Jérome Perrin's avatar
      ERP5: fix propertysheets for IdGenerator · c46511f4
      Jérome Perrin authored
      DublinCore was missing, so getCompactTitle was causing AttributeError
      _baseGetTranslatedTitle
      c46511f4
    • Jérome Perrin's avatar
      core: Workaround invalid html on AlarmTool_viewAlarmList · db1ddb54
      Jérome Perrin authored
      When listboxs has an editable field, but the field is non editable, it
      produces a markup like:
        <a href="link to the line"><EditableField/></a>
      This is fine for most fields, but some editable fields are rendered as
      an <input> even if they are not editable - this is the case for
      CheckBoxField.
      To prevent rendering <a><input></a> which is not valid HTML, configure
      the enabled field as non-editable on alarm list view, with this change
      listbox treats the field as an editable field and just render the field
      as <EditableField/> without the <a>.
      To keep the same visual appearance of having a disabled checkbox field,
      make this field disabled with extra.
      db1ddb54
    • Jérome Perrin's avatar
    • Jérome Perrin's avatar
      core/forge: fix scripts "Repository History" actions · 1fe56123
      Jérome Perrin authored
      The action was in erp5_core, but the form in erp5_forge. Move the action
      in erp5_forge.
      
      The listbox list method was raising error because it was using catalog
      with unsupported installation_state=. Change to use contentValues
      instead.
      
      This listbox had "Listbox" as a title, use "History" instead, which
      makes a little more sense in this context.
      1fe56123
  2. 26 Nov, 2019 3 commits
  3. 25 Nov, 2019 5 commits
  4. 22 Nov, 2019 8 commits