1. 04 Dec, 2018 6 commits
    • Jérome Perrin's avatar
      core: set SameSite=Lax on authentication cookie · 65882e59
      Jérome Perrin authored
      https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02
      
      We choose Lax and not Strict so that we can open links to ERP5 from
      external applications and so that OAuth Logins work. Implementing the
      "two cookies, one for read one for write" approach suggested in
      https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-8.8.2
      would be too big change at this point.
      65882e59
    • Jérome Perrin's avatar
      Cleanup google and facebook login and cookie management · ee05c9c4
      Jérome Perrin authored
      First,  cleanup `testERPSecurity`, moving related tests in sub-classes instead of big classes with lots of tests (diff is big, because methods are moved around)
      
      Change google and facebook login to reuse `portal.setAuthCookie`, which is the central point to set a cookie securely so that it can be used for authentication.
      
      Refactor management of oauth keys to fix [#20181121-1A36AE2](https://nexedi.erp5.net/bug_module/20181121-1A36AE2).
      
      Some minor fixes in business template definition.
      
      /reviewed-on !803
      ee05c9c4
    • Jérome Perrin's avatar
      Support Request: "Comment {Date,Author}" on frontpage · bab963e4
      Jérome Perrin authored
      Originally, there was a regression introduce in my recent changes that "Comment Author" column was always empty.
      
      This MR contains some more refactoring for "Comment Date" and "Comment Author" columns:
      
      ![image](/uploads/7b07a6a5610d533f1435af45b3716104/image.png)
      
      On the visible side, "Comment Date" column has been simplified, it used to show "hour:minutes" if the message was posted today, and "year/month/day" if the post was older. It's now a simple date time field (using `Base_viewCRMFieldLibrary/my_event_start_date`), for consistency.
      
      On the implementation side, they now use existing `SupportRequest_getCommentPostListAsJson` script, which simplified code a lot. That script was also renamed as `SupportRequest_getCommentPostList`, because it's no longer returning JSON.
      
      /reviewed-on nexedi/erp5!804
      bab963e4
    • Jérome Perrin's avatar
      Update ticket modification date when a new event is posted · e19743d7
      Jérome Perrin authored
      Some tickets (for example Support Request or Bugs) are focus on one small thing being discussed where usually a small number of events are posted.
      
      Unlike for example  a campaign where there is a large number of events sent to a large number of recipients, in the case of these "small, self contained" tickets, it makes a lot of sense to see that the ticket was modified when a new event is posted on this ticket.
      
      This is what we sometimes customize in some support request fast input. It was the case in Support Request App, but this was removed in 74fc68a7 , this time it's done at a lower level and such customisations are no longer needed.
      
      /reviewed-on !807
      e19743d7
    • Jérome Perrin's avatar
      officejs_support_request_ui: only display worklists involving Support Requests · 26d8e3b3
      Jérome Perrin authored
      Because this was displaying all worklists from ticket_worklist, which is
      also used for all tickets (including for example Campaigns) and that
      displaying other kind of tickets that Support Request is not supported
      on this app, we should filter the worklists to display only support requests.
      
      /reviewed-on !808
      26d8e3b3
    • Yusei Tahara's avatar
      testERP5Core: jump_related_object is lower priority now. See... · 2c56ad8a
      Yusei Tahara authored
      testERP5Core: jump_related_object is lower priority now. See 9e152672.
      2c56ad8a
  2. 30 Nov, 2018 4 commits
  3. 29 Nov, 2018 1 commit
  4. 28 Nov, 2018 1 commit
  5. 27 Nov, 2018 28 commits