These selection names were already used in other business templates:

   'web_page_module_view_web_page_list_selection'
	'WebPageModule_viewWebPageListAsJioForCodemirror/listbox': set(['erp5_officejs_codemirror'])
	'WebPageModule_viewWebPageListAsJioForTextEditor/listbox': set(['erp5_text_editor'])
	'WebPageModule_viewWebPageList/listbox': set(['erp5_web'])
	'DocumentModule_viewDocumentListAsJioForPdfViewer/listbox': set(['erp5_officejs_pdf_viewer'])
   'image_selection'
	'WebPageModule_viewWebPageListAsJioForSvgEditor/listbox': set(['erp5_officejs_svg_editor'])
	'ImageModule_viewImageList/listbox': set(['erp5_dms'])

The action was in erp5_core, but the form in erp5_forge. Move the action
in erp5_forge.

The listbox list method was raising error because it was using catalog
with unsupported installation_state=. Change to use contentValues
instead.

This listbox had "Listbox" as a title, use "History" instead, which
makes a little more sense in this context.

DublinCore was missing, so getCompactTitle was causing AttributeError
_baseGetTranslatedTitle

erp5_ingestion contained a skin folder for tests, with some proxy fields depending on erp5_web.
There was a proper test dependency to erp5_web, but in static analysis check we now check the skin folders, so it's no longer allowed to have some skin folder that are broken without test dependencies but not supposed to be used outside of tests.

When updating persistent to >= 4.4 __repr__ of zope objects display
information about ZODB connection, but it's more useful to have
information about the acqusition chain at this level.

One notable case was proxy field error messages, it was supposed to
include the path of the proxy field in the error message. This one is
fixed by fixing the MRO so that persistent.Persistent does not appear
first.

It's not used and does not respect naming conventions.

PropertySheetChild is not an acceptable prefix, use Base as the context
is used. Technically, this uses the "id as reference" mixin, but this
mixin is a bit special as it has takes the suffix as parameter and does
not reside in mixin module, so we just use Base as a prefix.

FieldValidator is not an acceptable prefix,
Base_validateDialogConfirmation seems better

Rounding scripts:

Planning is not an acceptable prefix, this script is called on the
current context, so let's use Base_ as a prefix.

Planning_roundBoundToMinute → Base_roundPlanningBoxBoundToMinute
Planning_roundBoundToDay → Base_roundPlanningBoxBoundToDay
Planning_roundBoundToInt → Base_roundPlanningBoxBoundToInt

Module is an acceptable prefix for modules

Introduce a list of skins IDs that does not match our conventions but
are acceptable because this is what external API are calling.

Some portal types such as Business Template were not tested by testXHTML
because this tests starts by modules and recursively tests based on
allowed content types. But types that are not created in a module but in
a tool were never tested.

Keep the current way of testing view of portal types in their natural
containers by starting from modules and make another pass to test anyway
portal types that might be contained in tool. In that case, we use a
mapping of known tools IDs because I don't think we can introspect at
this point.

We want this check to run on all components.

Without this, subclassing defining this method will have rguments-differ
pylint warning because the signature of Base._checkConsistency is
different.

This `o` was an unused variable. The initial intention was probably
this.

This will allow to find problems when only business templates and their
dependencies are installed. When we run testXHTML with all business
template installed we don't see problems that may happen only when some
business templates are not installed.

These scripts are used to check the site configuration and also in
CodingStyleTest.

This is just the minimal so taht CodingStyleTest can run, but this could
be extended to several scripts currently in erp5_toolbox skinfolder of
erp5_forge which overlaps with erp5_administration.

checkRevision now returns a callable, return a do-nothing lambda when
the expected revision is already checked out

/reviewed-on !990

With this merge request we add the feature of allow a gadget to call submitDialog  *and* the prototype of scan documents from mobile with new ERP5 UI

/reviewed-on nexedi/erp5!932

For now, this is chrome only

erp5_document_scanner_ui_test: Add tests to Document Scanner gadget

- tests updated

- test extended

If automatic GC happens just after the testnode repository is updated,
the repository in the SR may lose objects and fail to update.

See commit 9634a7d8.