cf commit 550e81b0

CMF 2.3 is "stricter" about Unauthorized exceptions, and will always
redirect to the login page.

cf commit c3bde10e

Products.CMFCore.CookieCrumbler's redirect support was moved to
Products.CMFDefault in CMF 2.3, cf:
- CMFCore: 387bd379fd9655aa1462715a04b4664f5c54974a
- CMFDefault: d319a68e8299e42a76f605ad79383bb78db14031

Registering portal_actions allows CMFDefault to redirect correctly,
cf UnauthorizedView.__call__

Also some code refactoring.

ICookieCrumbler.credentialsChanged signature changed in Products.CMFCore
2.3.0-beta. We also update the patch on the same occasion.

... so that queryUtility can later access the correct ones.

Note: we do not necessarily want to register all tools.

It is no longer supported in CMF 2.3, see Products.CMFCore
754894460271f8562d03e8c51e6efcee7223a3ba.

It is no longer supported in CMF 2.3, see Products.CMFCore
be875bb45272ad6ad3c2e14d72a41295dc7389cf.

getToolByName(portal, 'portal_skins').REQUEST: AttributeError

This is a fixup for commit 1519d81a.

There was a typo.

This test was using a blind `pause` instead of an explicit waitFor*, so
it was failing when machine was not fast enough.

Also refactor the test a bit to simplify the assertion by first
selecting the iframe we are going to inspect and make the test
compatible with both chrome and firefox - they behave differently when
interpreting new lines in selenium test tables.

/reviewed-on nexedi/erp5!967

We want to have FAILED test results before PASSED, to easily see the
failed tests.

Apparently this was a local change on nexedi ERP5 for some time but the
change got lost in last update. Let's commit it to make this
permanent.

/reviewed-on nexedi/erp5!960

test_04c_startTestSuiteOrderWithManyTestNodes is using same test results
names ("test suite 1", "test suite 2", ...) as some previous tests (
test_04b_startTestSuiteOrder ) so it's safer to start the test by
cancelling all previous test runs and renaming them.

/reviewed-on nexedi/erp5!959

erp5_trade_ja: New bt5 for wkhtmltopdf printout for 'Sale Invoice' with >2019/10/01 new Japanese VAT ratio support.

Based on the following ODT Templates (erp5_invoicing):
  * Invoice_viewAsODT.oot.
  * Invoice_viewAsODTStyles_l10n_ja.oot.

wkhtmltopdf template is based on work from slapos_accounting bt5:
  * SaleInvoiceTransaction_viewSlapOSPrintout.zpt.
  * SaleInvoiceTransaction_getSlapOSPrintout.css.zpt.

Conversion Server code is no longer bound to OOo, as emphasized by:
  * Renaming of Preference Properties ooodoc_server* to document_conversion_server*.
  * Conversion Server exceptions are already defined in Document.py.
  * Conversion Server also handles video/audio/... conversions.

Thus, refactor the code to connect to Conversion Server by moving it from
Products.ERP5OOo.Document to Products.ERP5.Document.Document (while keeping
backward compatibility):
  * Renamed:
    + OOoServerProxy => DocumentConversionServerProxy
    + OOO_SERVER_PROXY_TIMEOUT => DOCUMENT_CONVERSION_SERVER_PROXY_TIMEOUT
    + OOO_SERVER_RETRY => DOCUMENT_CONVERSION_SERVER_RETRY
  * Moved:
    + enc
    + dec
    + global_server_proxy_uri_failure_time

Also, Introduced erp5.module.TransformLib (in erp5_core as currently all Transforms
are there even though it should probably not be so) to define DocumentConversionServerTransform
and which will hold libtransforms content when this will be moved to ZODB Components.

Note: Ideally, OOOdCommandTransform should inherit from DocumentConversionServerTransform
but wkhtmltopdf Handler on Cloudooo side is a hack only implemented in Manager.convertFile()
whereas OOOdCommandTransform still uses legacy Manager.run_generate(), so leave it as it is
to avoid breaking things (this will be addressed in a separate MR).

/reviewed-on !955

/reviewed-on nexedi/erp5!965

ZODB Components: Add 'Origin' (source_reference) field showing from which FS module it was imported.

* pylint may return a false positive error which have to be disabled and
  failing to import it because of that requires to edit on the FS and try
  again so it is not practical for a whole Product. Instead it is easier
  to import it and not validate
* Validation was done only for 'Test Component' and 'Extension Component',
  but all imported Components had their consistency and source code checked
  and this is not consistent to not validate but do these checks.
* importFromFilesystem() was checking consistency and source code, and this
  was done again when validating.

So leave the imported ZODB Components as draft and let the developer fixes
issues upon validation before committing.

ZODB Components: List of migratable 'Module Components' in Products.XXX.* should include any kind of objects and not only modules.

This fixes Products.ERP5VCS.Git module not being displayed because
Products.ERP5VCS.__init__ only imports one of its class and not the whole
module (and the module was not imported anywhere else too) so it was not in
Products.ERP5VCS.__dict__.

useStdin=False => temporary file was not created.
useStdin=True  => temporary file was created.

When multiple repositories exists and two of them contain scalability_test package be wiser and really check if neeeded Test Suite class exists before trying to load it.

When running tests the path to git command is just git, because we have
set $PATH

updateConfiguration is a method to set the list of partitions, not to
add partitions to an existing computer. The previous (slapos.core
<1.5.0) implementation of slap proxy was incorrect and was adding more
partitions each time it was called, but that was never the indented
behavior.

Prepare the list of partitions and call updateConfiguration only once to
set all partitions.

This should fix SLAPOS-SR-TEST that are still using erp5.util

Some tests where patching SlapOSControler to replace methods by a no-op,
but this was never reset. I believe we should rewrite this using mock
which takes care of un-doing the patches for us and makes this testing
easier, but for now I'm just reseting the missing methods like all
others were already reseted.