Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1021

Merged
Created Dec 27, 2019 by Jérome Perrin@jeromeOwner

Check forms in coding style

  • Overview 5
  • Commits 56
  • Pipelines 12
  • Changes 256

Extend coding style tests to check forms:

  • Method Name Is Prefixed With Portal Or Meta Type, Class Or Interface / Set Document Form Ids To PortalType_view - this was checked for python scripts, but not yet for dialogs
  • Form Name Uses Lowercase View After Portal Type
  • Dialog Form Name Is Postfixed With Dialog
  • Report Name Uses Portal Type Followed By View Report Name And Report
  • Place Simulation And Validation Fields At Bottom Of Right Group
  • Use Correct Names For Simulation And Validation Titles

and apply minimal fixes to all business templates already running coding style checks.

Edited Dec 10, 2020 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: feat/coding_style_form_naming
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7