ERP5Type/patches/ZODBConnection: Don't duplicate code from ZODB.Connection.newTransaction
Commit c663257f (Commit fix done by Julien and Leonardo) added network barrier into ZODB.Connection.newTransaction to fix issues when activity node A1 was woken up by message from another activity node A2 through SQL, but A1's ZODB view was not yet updated with changes committed by A2.
That fix prepended ping call before original newTransaction actions,
but instead of tailing to original ZODB newTransaction after the ping,
it copied newTransaction code from ZODB.
Today this can cause the following problems:
-
the code that was copied is valid only for ZODB3 and ZODB4, but is not valid for ZODB5 as that place was changed by upstream:
https://github.com/zopefoundation/ZODB/blob/5.5.1-56-gbb9bf5393/src/ZODB/Connection.py#L734-L742
-
wendelin.core 2 relies on patching ZODB.Connection.newTransaction further to install "Connection.onResyncCallback" functionality to keep ZODB and WCFS connections in sync:
https://lab.nexedi.com/kirr/wendelin.core/blob/25c3184d/lib/zodb.py#L264-291
So if ERP5Type.patches is imported after wendelin.lib.zodb, the functionality installed by wendelin.core will be lost.
-> Fix both issues by avoiding code duplication and just tailing to original ZODB newTransaction after the ping.
Note: this commit is not enough to fully support ZODB5, since ping() must also be updated.
/cc @seb, @jm, @vpelletier, @romain