Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 141
    • Merge requests 141
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1174

Merged
Created Jul 01, 2020 by Jérome Perrin@jeromeOwner

base: don't allow selecting draft currencies by default

  • Overview 4
  • Commits 1
  • Pipelines 5
  • Changes 4

The initial intention was to "disallow invalidated", without forcing users to validate everything, but it was probably a mistake, if users don't need to validate then validation workflow would be a bit meaningless.

This is made after an incident where a user mistakenly cloned a validated currency and the cloned currency was available everywhere in the system.

Change to not return draft currencies by default and also change so that all items are tuple, for consistency. That should have no impact and is a bit easier for the test.

Also adjust accounting_ui_test, we need to validate currencies for the tests and clear cache if we validated some (but we don't need to clear cache if we validate accounts, because account caches is more clever and does not need to clear all cache)

Edited Jul 02, 2020 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: feat/validated_currency
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7