Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1190

Merged
Created Jul 07, 2020 by Arnaud Fontaine@arnauDeveloper

OAuthTool: Used only as a Folder ({Google,Facebook}Connector) so remove {unused,unmaintained,unfinished} code.

  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 33

Properties are statically sets on portal_oauth directly with classes define in OAuthTool.py. This prevents migration to ZODB Components as erp5_oauth could not be upgraded anymore (chicken & egg issue: we need these classes portal_templates.download() (importFile(portal_oauth.xml)) but they are not available until the bt5 is installed...).

Considering that several properties are supposed to be private but statically set in OAuthTool.py (and it seems there is no way to change them), and that this code has never been used since its introduction 9 years ago, I think it is better remove that code than trying to fix it properly.

@nexedi @aurel Is that ok with you? (All Unit Tests pass) I will wait a few days for anyone to reply and then merge.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: arnau-RD-Components-ERP5TioSafe
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7