Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1191

Merged
Created Jul 07, 2020 by Gabriel Monnerat@gabrielDeveloper

WIP: Move RSS link and reuse generic view actions

  • Overview 23
  • Commits 6
  • Changes 40
  • Having a big "Generate RSS" button on the front page was strange, because the front page button are for common use cases that users are supposed to execute a lot. For example makes sense to have a "Submit new Support Request" button, because users are using this app to submit support requests, but generating RSS is very exceptional action, so we wanted to remove it from the front page.

  • The view of support requests in the app is a new "Discussable" page, where users can post comments and attach documents to their posts. If they attach document, a link to that document is displayed in the discussion thread. The problem was that this link was never really correct, depending on the portal type of the attached document. This was never really working, because the code here was taking the 1st action for image and 4th action for documents we believe that this was made to use the "preview" action of the portal type, but depending on the order of actions we had different results. This was simplified by extending ERP5JS router with display_erp5_action_with_history. With this, we can select preview or html_view action view to each document attachment.

Edited Aug 05, 2020 by Gabriel Monnerat
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: rss_link_and_new_category_action
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7