WIP: inconsistent listbox proxy fields for modules
- Loading...
Since 76282344 , most modules do not have a count method anymore.
But not all of them, because we have two proxy fields for listboxs , my_list_mode_listbox and my_view_mode_module_listbox that are not used consistently.
$ git grep my_list_mode_listbox | wc -l
196
$ git grep my_view_mode_module_listbox | wc -l
64
According to https://www.erp5.com/erp5-HowTo.Configure.Proxy.Field/erp5-Guideline.Form.Profixification/#the-semantic-field-name-needs-to-be-associated-with-the-technical-context the technical_context_name
for module listbox is list_mode
, so my understanding is that modules should not use my_view_mode_module_listbox because this is not view_mode, so my_list_mode_listbox sounds better.
I am planning to change all users of my_view_mode_module_listbox to use my_list_mode_listbox , but I would like to make sure my understanding is correct and we agree on this.
Check out, review, and merge locally
Step 1. Fetch and check out the branch for this merge request
git fetch "https://lab.nexedi.com/jerome/erp5.git" "listbox_module_proxy_field" git checkout -b "jerome/erp5-listbox_module_proxy_field" FETCH_HEAD
Step 2. Review the changes locally
Step 3. Merge the branch and fix any conflicts that come up
git fetch origin git checkout "origin/master" git merge --no-ff "jerome/erp5-listbox_module_proxy_field"
Step 4. Push the result of the merge to GitLab
git push origin "master"
Note that pushing to GitLab requires write access to this repository.
Tip: You can also checkout merge requests locally by following these guidelines.
- You're only seeing other activity in the feed. To add a comment, switch to one of the following options.