Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1272

Merged
Created Sep 23, 2020 by Jérome Perrin@jeromeOwner

accounting: fix validation of accounting transactions with too precise amounts

  • Overview 5
  • Commits 1
  • Pipelines 3
  • Changes 11

Round the amounts line by line when validating transactions balances and showing the totals on an accounting transaction.

Even though float field configurations do not allow users to input transactions where amounts uses more digits that what makes sense for the selected currency, we had cases where some transactions generated by custom scripts were "too precise" and passed the validation because unlike in all reports where we display sum of rounded values, the check was only rounding the sum, which cause some transactions with 1.00 on one side and 0.333333 0.333333 and 0.333333 on the other side to be valid.

The scripts used to display sums on an accounting transaction had the same problem, they were also showing the rounded sum and not the sum of rounded values.

Edited Sep 23, 2020 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/accounting_rounding_validation
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7