Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1323

Merged
Created Dec 24, 2020 by Jérome Perrin@jeromeOwner

authentication_policy: fix UnicodeDecodeError with invalid password messages

  • Overview 7
  • Commits 1
  • Pipelines 2
  • Changes 3

When new password does not match policy, in reset password and change password dialogs, we used u' '.join([str(message) ...]) to join all translated messages in a string, but this construct will decode the str(message) to unicode using ascii, so it will fail when these messages contain some multi bytes characters.

Extend test coverage to check that these dialogs uses translations and use non ascii messages in the tests, to make sure we don't have regressions with this issue.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/change_password_policy_unicodeerror
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7