Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 143
    • Merge requests 143
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1336

Merged
Created Jan 15, 2021 by Jérome Perrin@jeromeOwner

accounting: Fix timezone issues when checking periods are consecutive

  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2

Opening an accounting period is refused if the start date of the period is more than one day after the stop date of the previous period, but this check did not take into account that "next day" might be more than 24 hours, like it's the case when daylight saving happen between these dates. Instead we check that the difference is less than 1.9 days.

Reorganise tests to group accounting period related tests in a dedicated test class and add missing tests for period validation checks.

Also fix a few race conditions with catalog indexing that are probably not a problem in real life but were revealed by the test.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/accounting-period-dates-timezone
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7