Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1374

Merged
Created Mar 11, 2021 by Jérome Perrin@jeromeOwner

deferred_style: Properly keep request parameters

  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 10

When rendering reports, deferred style was only keeping request.other, but some places, like Products.ERP5Form.ListBox.ListBox.getParamDict read only in request.form, which caused different behaviours when rendering reports directly or in activities, because when rendering in activities request keys that the report dialog might have pushed were not preset in request. They were of course present when rendering the report directly, because this was the same request, so this lead to different behaviours wether reports were rendering in activities or directly, like we could observe in 7058ab6f (accounting: fix grouping option of GL when running in deferred mode, 2021-02-25)

This change deferred style to properly propagate request.other and request.form in all activities of reports.

Edited Mar 29, 2021 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/deferred_style_keep_request_form
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7