Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 141
    • Merge requests 141
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1380

Open
Created Mar 22, 2021 by Kazuhiko Shiozaki@kazuhikoOwner
  • Report abuse
Report abuse

DateUtils (addToDate): compute day offset in local time manner.

  • Overview 10
  • Commits 1
  • Changes 2

if timezone is Europe/Paris, we expect :

'2021/03/28' + 1 day => '2021/03/29 GMT+1', NOT '2021/03/29 GMT+2.

i.e. 'same time' in the next day.

'2021/03/28' + 3 hours => '2021/03/28 04:00 GMT+2', NOT '2021/03/28 03:00 GMT+1'.

i.e. valid timezone offset at the result time.

because of lacking such support, we need to write very dirty code like the following :

begin_next_month = DateTime((addToDate(DateTime(now.year(), now.month(), 1), month=1) + 0.5).strftime('%Y/%m/%d'))

instead of :

begin_next_month = addToDate(DateTime(now.year(), now.month(), 1), month=1)
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: addToDate_implicit_localtime
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7