Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !173

Closed
Created Oct 04, 2016 by Jérome Perrin@jeromeOwner0 of 2 tasks completed0/2 tasks
  • Report abuse
Report abuse

WIP: Support sending SMS more than 140 characters long

  • Overview 1
  • Commits 4
  • Changes 4

This is a WIP merge request with the patchs so that portal_sms supports sending SMS more than 140 characters long.

For now, we implemented that for mobyt only without taking care of other gateway implementations.

When discussing with @gabriel on eb7abe51 , we considered ( at least ) the following tasks :

  • Maybe message_type should become a property of the gateway and not be defined in ShortMessage_send.
  • The API endpoint is http. Using the same URL with https seems to work.

We also said that (this seems less critical):

  • (jerome) This API is old, I found the doc using archive.org wayback machine. The new API is slightly different, so I am not sure we want to implement that.
  • (gabriel) I think API URL should be also part of the gateway(or at least set a default and be editable)
  • (gabriel) move getAllowedMessageType to ERP5 (as script or categories?). (jerome) but I think that the possible messages types varies from one gateway to another, so in what I have in mind, each gateway implementation must define the possible allowed message types and let the user choose
  • (jerome) With mobyt, messages with more than 140 characters are rejected when using text mode, if we use MULTITEXT, multiple messages are sent. This also means that the cost of sending such message is higher. Probably we want a way to configure we want to send only one message and fail if messages are too long instead of sending multuiple messages and increase the cost of sending.
  • (jerome) the whole product/ERP5ShortMessage can be moved to components, as we are doing in !172 (closed)
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: sms_more_than_140_characters
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7