Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1733

Merged
Created Jan 25, 2023 by Jérome Perrin@jeromeOwner

credential: stop using deprecated property for email

  • Overview 2
  • Commits 1
  • Pipelines 6
  • Changes 6

In 44e0b22f (Move to new API, detailed properties take precedence, 2011-09-09) we introduce a new data model for coordinates, in the case of emails, we have "url_string" fro the "detailed" form and "coordinate_text", for the "store what user entered" form.

In some places of erp5_credential, we use setDefaultEmailText, which calls Coordinate.setText which uses the deprecated Coordinate.fromText, which sets the same value for "url_string" and "coordinate_text", which seems a questionnable behavior, because the data is saved twice and some code might be using the wrong property.

This changes every usage to the new coordinate_text property

Edited Jan 30, 2023 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/credential_email_url_string
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7