Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1776

Merged
Created Apr 25, 2023 by Jérome Perrin@jeromeOwner

core: expose `is_source` on `MovementHistoryListBrain`

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 7

This can be useful when making a report on movements and when we list properties of the movements that depend on the side but are not directly exposed on MovementHistoryListBrain. One use case was Movement_getSpecificReference, which shows source_reference when the brain is for the source and destination_reference otherwise.

With this new approach, instead of guessing we record the "is_source" information at indexing time, when we know this for sure.

This also simplifies MovementHistoryListBrain.date and MovementHistoryListBrain.mirror_date which no longer need to guess the side and fix a problem that because this guessing was done using movement.getSourceUid() - which cause security errors when users can not access the source of the movement.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: feat/brain_is_source
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7