Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1835

Merged
Created Oct 26, 2023 by Jérome Perrin@jeromeOwner

dms: version up pdfjs 3.11.174

  • Overview 3
  • Commits 1
  • Pipelines 3
  • Changes 268

using pdfjs-3.11.174-legacy-dist.zip

Note: viewer.js is modified to do nothing in webViewerLoad (one line with return "ERP5 patch: disable here" is added at the top of this function) because we do the initialization in the gadget. I think something similar was also done with the previous version.

The tests were extended to cover:

  • opening an empty or broken PDF: this should not crash
  • clicking save: this should not crash and the updated document should render properly. The save action replaces the ERP5 document content with the content from the editor, so if user for example added annotations or draw on the PDF, the modified version is saved. We don't use this feature and it's not so easy to test, so for now the test only covers the "it should not crash and it should not break the document".
  • entering wrong password for encrypted PDFs should not crash
Edited Nov 16, 2023 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: feat/pdfjs_up
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7