Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1913

Closed
Created Apr 10, 2024 by Carlos Ramos Carreño@vnmabusDeveloper
  • Report abuse
Report abuse

Do not overwrite `output.write` in live tests.

  • Overview 12
  • Commits 40
  • Changes 772

The write method of the output object was being overwritten in live tests, replacing it to a function that printed both to the output and to stdout. This was not necessary, as it is possible to use this function directly. Moreover, the function code had two flaws:

  • It assumed that output was a particular (StringIO) class. This caused a problem during the migration (commit 80bd30fc).
  • It printed to stdout instead to stderr.

Using the function directly allows output.write to be used inside it, preventing the first flaw. The second flaw has also been solved.

Edited Apr 10, 2024 by Carlos Ramos Carreño
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: feature-live-test-output-write
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7