Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1925

Merged
Created Apr 19, 2024 by Carlos Ramos Carreño@vnmabusDeveloper

Fix erp5 interface post in Python 2

  • Overview 3
  • Commits 2
  • Changes 1

The e-mail messages are normalized in a way compatible with both Python 2 and Python 3.

In Python 2, the previous version added a unixfrom, which contains the date, making the tests fail when there is a change of one second in the clock between generating the first and the second message. Moreover, the second message contained a previous unixfrom. This has been solved by removing unixfrom in the normalized string.

In Python 3, messages had an inconsistent folding, due to https://github.com/python/cpython/issues/72649 . This has been solved by manual unfolding (using a regex substitution) and by outputing normalized strings without folding (setting maxheaderlen=0, which means no maximum line lenght).

With these changes, the normalized string can be compared in both versions without problems.

In addition, some bare encode/decode calls were replaced by the appropriate methods.

Tests passed locally and a test suite is in progress.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/erp5_interface_post_py2
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7