Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !2034

Merged
Created Jan 02, 2025 by Nicolas Wavrant@NicolasMaintainer

[renderjs_ui] Support infinite listbox

  • Overview 0
  • Commits 3
  • Changes 5

Just like in the xhtml_style UI, there are times we want to disable the paginating feature of a listbox, to show all the results on one page.

From what I see in the code, there was a partial support for it, but the current behavior was to limit to 10 results. I'm not sure if this feature was never supported in renderjs_ui, or if a bug has been introduced later. Anyway, the main part of the fix results from the supposition that there is a type-encoding issue somewhere in the chain renderjs_ui <-> jIO <--> JSON conversion <--> ERP5 HAL/REST API.

This patchset brings (or restores) the support for infinite listboxes, and add a test to prevent any future regression.

The default limit of 10 comes from the default value of the property "limit" of ERP5Document_getHateoas. I decided to keep it, as it can prevent configuration errors that would misfire otherwise. Instead, I handle explicitely the case where "limit" is set to 0, which must be configured purposely and conciously by the developers.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: nicolas-infinite-listbox
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7