Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !2036

Merged
Created Jan 05, 2025 by Jérome Perrin@jeromeOwner

base: make Entity_sendEmail raise early for missing email addresses

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

on python2, this sends an email with address like "Name <None>", on python3 this fails with an error like this:

  Module script, line 15, in Entity_sendEmail
   - <PythonScript at /portal_2664097758140587659/Entity_sendEmail used for /portal_2664097758140587659/person_module/20241227-13AB7>
   - Line 15
    from_url = formataddr((sender.hasTitle() and sender.getTitle(), sender.getDefaultEmailText()))
  Module email.utils, line 92, in formataddr
    address.encode('ascii')

better to fail early in such a case

Edited Jan 06, 2025 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/no_email
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7