Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !2111

Merged
Created May 28, 2025 by Jérome Perrin@jeromeOwner

OOoUtils: fix `OOoBuilder.replace` creating duplicate entries in zipfile

  • Overview 7
  • Commits 1
  • Pipelines 8
  • Changes 3

This cleans up the API a bit:

  • OOoBuilder.updateManifest is no longer a public API, OOoBuilder handles manifest by itself and it's not necessary to call this method.
  • creating an OOoBuilder from an open file-like is no longer possible, it was not clear what the use case for this was.

Internally, this new implementation works by opening the zip file in the constructor and keeping the content of each file in a dict.

Edited Jun 06, 2025 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/OOoUtils_duplicate_zip_entries
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7