Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !222

Merged
Created Jan 12, 2017 by Jérome Perrin@jeromeOwner

More authentication policy fixes after switch to login

  • Overview 11
  • Commits 11
  • Changes 20

This contains the remaining fixes around authentication policy after the introduction of ERP5 Login.

Here I am changed API so that login_account_provide's analyzePassword directly returns the messages instances and not error code, this way we can easily use analyzePassword to check passwords in various password fields validator.

You may think "why don't we use the same script for all validators ?", the answer is that depending on the context, the logic to find the login for which we want to check the password is different ( when "changing own password", it is the currently logged in user, in portal password password reset it is as we dicussed in !185 (comment 19760) , in new user creation dialog it would also be different), so it makes sense to have different validator scripts all reusing analyzePassword .

This was applied to Password tool to fix #20161021-F85D7 and also to Preference's tool "change own password" dialog.

There are other small fixes.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/check_authentication_policy
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7