Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !327

Merged
Created Jul 24, 2017 by Łukasz Nowak@lukeDeveloper

CMFActivity adapt hasErrorActivity to modern API

  • Overview 4
  • Commits 4
  • Changes 5

ActiveObject and ActiveProcess provide hasErrorActivity method, which shall return True only in case when there is errornous activity related to given document (be it object or process).

Unfortunately those methods weren't tested and because of obsoletion of processing_node parameter, they were failing.

This MR provides:

  • addition of invalid_only parameter, which allows to check if there is any message which is failed (and failed is -2)
  • test covering various cases for hasActivityError
  • fix for hasErrorActivity using the invalid_only parameter
  • small reorganisation of global, which is not needed in ActiveObject anymore

Attached testCMFActivity.txt contains test result of testCMFActivity.py from source branch.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/hasErrorActivity
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7