Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !77

Merged
Created Mar 15, 2016 by Georgios Dagkakis@georgios.dagkakisDeveloper

BusinessTemplate.py: PortalTypeWorkflowChainTemplateItem during build

  • Overview 11
  • Commits 2
  • Changes 83

add 'portal_type_workflow_chain/' to the type of the workflow_chain_type as it is added also in _importFiles (https://lab.nexedi.com/nexedi/erp5/blob/master/product/ERP5/Document/BusinessTemplate.py#L2693).

@romain spotted this issue here https://lab.nexedi.com/nexedi/erp5/blame/master/bt5/erp5_web_renderjs_ui/PortalTypeWorkflowChainTemplateItem/workflow_chain_type.xml

Since migration only imported and exported without building, in the file we have now:

<type>portal_type_workflow_chain/Web Script</type> 

If someone uses git tab though, BT is built and 'portal_type_workflow_chain/' is eliminated and there is unexpected diff. This commit adds 'portal_type_workflow_chain/' also in build. I do not think I see something different in portal_workflow and no unexpected test failures (https://nexedi.erp5.net/test_result_module/20160314-2D78E1FA). Other option might be to remove it from L2693 and re-migrate to updated those files. @seb @jerome do you have any opinion in this?

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: portal_type_workflow_chain
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7