Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !804

Merged
Created Nov 22, 2018 by Jérome Perrin@jeromeOwner

Support Request: "Comment {Date,Author}" on frontpage

  • Overview 8
  • Commits 3
  • Pipelines 1
  • Changes 11

Originally, there was a regression introduce in my recent changes that "Comment Author" column was always empty.

This MR contains some more refactoring for "Comment Date" and "Comment Author" columns:

image

On the visible side, "Comment Date" column has been simplified, it used to show "hour:minutes" if the message was posted today, and "year/month/day" if the post was older. It's now a simple date time field (using Base_viewCRMFieldLibrary/my_event_start_date), for consistency.

On the implementation side, they now use existing SupportRequest_getCommentPostListAsJson script, which simplified code a lot. That script was also renamed as SupportRequest_getCommentPostList, because it's no longer returning JSON.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/support-request-comment-date
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7