Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !86

Open
Created Mar 22, 2016 by Georgios Dagkakis@georgios.dagkakisDeveloper
  • Report abuse
Report abuse

[WIP] Do not use prefix importing objects of classes where the prefix is not used

  • Overview 6
  • Commits 0
  • Changes 0

in the export path. These classes are:

  • PortalTypeWorkflowChainTemplateItem
  • PortalTypeRolesTemplateItem
  • PortalTypeAllowedContentTypeTemplateItem
  • PortalTypeHiddenContentTypeTemplateItem
  • PortalTypePropertySheetTemplateItem
  • PortalTypeBaseCategoryTemplateItem

In each class the prefix is used only in preinstall both for current business template and the previously installed ones. The use of prefix in preinstall is twofold:

  • To have unique keys in the dictionary of modified objects
  • To preserve compatibility with old business templates

@jerome @tc I submit since we already talked about this issue to check mostly on the below:

  • This way we use manual prefix only in preinstall. Since it is not fully eliminated though I do not know how much it is worth to apply.
  • Do you know why different classes are exported using different folder structures? I mean for example:
    • PortalTypeWorkflowChainTemplateItem objects (workflow_chain_type.xml) are exported directly to the folder.
    • PropertySheetTemplateItem objects are exported in a sub-folder named portal_property_sheets. The intermediate layer is always empty I think, i.e. nothing is exported directly to PropertySheetTemplateItem folder.
  • I have no idea how compatibility to business templates installed with previous revision of code can be automatically tested.
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: remove_prefix_squash
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7