Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Repository

Switch branch/tag
  • erp5
  • bt5
  • erp5_oauth_facebook_login
  • TestTemplateItem
  • portal_components
  • test.erp5.testFacebookLogin.py
Find file BlameHistoryPermalink
  • Romain Courteaud's avatar
    core: set SameSite=Lax on authentication cookie · c4bd6cd2
    Romain Courteaud authored Jan 15, 2020
    https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02
    
    SameSite=None breaks the compatibility with some browser versions.
    https://www.chromium.org/updates/same-site/incompatible-clients
    
    We choose Lax and not Strict so that we can open links to ERP5 from
    external applications and so that OAuth Logins work. Implementing the
    "two cookies, one for read one for write" approach suggested in
    https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-8.8.2
    would be too big change at this point.
    
    Allow instances to surcharge the SameSite value for some specific domains if needed,
    by surcharging the ERP5Site_getAuthCookieSameSite script.
    c4bd6cd2

Replace test.erp5.testFacebookLogin.py

Attach a file by drag & drop or click to upload


Cancel
GitLab will create a branch in your fork and start a merge request.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7