Commit 03e60de1 authored by Julien Muchembled's avatar Julien Muchembled

MailTemplates: more reliable encoding of headers

str.encode() first performs an implicit conversion to unicode using
sys.getdefaultencoding(), which is usually 'ascii'. The 'isort' module
changes the default encoding to utf-8, leading to UnicodeEncodeError
instead of UnicodeDecodeError. Let's simplify all this.
parent 0d88e7a0
......@@ -80,26 +80,19 @@ class BaseMailTemplate:
if value is not None:
# turn some sequences in coma-seperated strings
if isinstance(value, (tuple, list)):
value = ', '.join(value)
# make sure we have no unicode headers
if isinstance(value,unicode):
value = value.encode(encoding)
if key == 'subject':
# Try to keep header non encoded
value = Header(value.encode("ascii"))
value = Header(value)
except UnicodeDecodeError:
value = Header(value, "UTF-8")
value_list = getaddresses([value])
dest_list = []
for name, email in value_list:
for name, email in getaddresses((value,)
if isinstance(value, basestring) else value):
name = Header(name.encode("ascii"))
name = Header(name)
except UnicodeDecodeError:
name = Header(name, "UTF-8")
dest_list.append(formataddr((name.encode(), email)))
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment