fixup! runUnitTest: ZODB is removed on '--save', so also remove all the tables of the SQL database

product/ERP5Type/tests/custom_zodb.py

@@ -56,15 +56,14 @@ if load:
       _print("Could not find MySQL dump (%r), will recreate catalog ... " % dump_sql_path)
       os.environ['erp5_tests_recreate_catalog'] = '1'
   _print("Restoring static files ... ")
-elif save:
-  if not (neo_storage or zeo_client) and os.path.exists(data_fs_path):
+else:
+  if save and not (neo_storage or zeo_client) and os.path.exists(data_fs_path):
     _print("About to remove existing Data.fs %s (press Ctrl+C to abort)" % data_fs_path)
     time.sleep(5)
     os.remove(data_fs_path)
 
-# Whether passing --save or not passing both --load and --save, the catalog
-# must be cleared of data from previous execution if any
-if not load:
+  # Whether passing --save or not passing both --load and --save, the catalog
+  # must be cleared of data from previous execution if any
   _print("Catalog will be recreated to clear data (if any) from previous execution")
   import Products.ZMySQLDA.db
   sql_db = Products.ZMySQLDA.db.DB(os.environ['erp5_sql_connection_string'])

[Arnaud Fontaine]

@jm Could you please explain why this was necessary?

[Julien Muchembled]

Not necessary. In the MR, I suggested to change like this and you didn't object, but at the end you merged without it and I supposed it ww

[Julien Muchembled]

as forgotten.

[Arnaud Fontaine]

Ah sorry, I must have missed it indeed. Thanks for the fix.