1. 21 Aug, 2019 1 commit
    • Julien Muchembled's avatar
      Publish Folder.recursiveReindexObject · fa64d07f
      Julien Muchembled authored
      With the removal of Folder_reindexAll, it has become laborious to reindex
      a whole module, and it was often done in an unsafe way (create a dummy wrapper
      script in custom skin folder, without thinking about security).
  2. 07 Aug, 2019 2 commits
  3. 06 Aug, 2019 2 commits
  4. 05 Aug, 2019 2 commits
  5. 02 Aug, 2019 8 commits
  6. 01 Aug, 2019 3 commits
  7. 31 Jul, 2019 2 commits
  8. 30 Jul, 2019 1 commit
  9. 29 Jul, 2019 2 commits
  10. 26 Jul, 2019 4 commits
  11. 25 Jul, 2019 4 commits
    • Vincent Pelletier's avatar
      CMFActivity.ActivityTool: Set exc_type default value. · 3123e1a9
      Vincent Pelletier authored
      This property is only conditionally set, which causes distracting error
      when something goes wrong. If we really want to check that the expected
      code path was followed there has to be a better check and a more debugging-
      friendly error than an AttributeError.
    • Vincent Pelletier's avatar
      CMFActivity.Activity.SQLBase: Tolerate group_id set without a grouping_method_id. · e80c4f06
      Vincent Pelletier authored
      While such activity parameter combination does not make sense, it is
      technically possible to spawn activities with a group_id set but without a
      The consequence is zombie activities: they never fail, do not prevent other
      activities from being executed, but and are permanently run on the node
      which reserved more than one because:
      - all but one activity is in MESSAGE_NOT_EXECUTED state, forcing an abort
      - finalizeMessageExecution does not understand that MESSAGE_NOT_EXECUTED
        activities may not have failed, and itself fail while trying to detect
        the failure type (ConflictError vs. others), failing to free & postpone
        the activity, in turn failing to bring it to eventually permanent failure
      Make those conditions consistent, and use tuple-unpacking to detect any
      future inconsistency much earlier, simplifying debugging.
    • Vincent Pelletier's avatar
      CMFActivity.Activity.SQLBase: Expect group_method_id to always be a string. · 5a45b0e1
      Vincent Pelletier authored
      group_method_id column is declared "NOT NULL", so it can only be None if
      getProcessableMessageList could not find any activity, in which case this
      code is not executed ("if message_list" is false).
      This simplifies two "if" statements.
    • Vincent Pelletier's avatar
  12. 23 Jul, 2019 1 commit
  13. 22 Jul, 2019 2 commits
  14. 19 Jul, 2019 1 commit
  15. 18 Jul, 2019 5 commits