Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5
erp5
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Merge Requests 109
    • Merge Requests 109
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Jobs
  • Commits
  • nexedi
  • erp5erp5
  • Merge Requests
  • !1021

Merged
Opened Dec 27, 2019 by Jérome Perrin@jerome
  • Report abuse
Report abuse

Check forms in coding style

Extend coding style tests to check forms:

  • Method Name Is Prefixed With Portal Or Meta Type, Class Or Interface / Set Document Form Ids To PortalType_view - this was checked for python scripts, but not yet for dialogs
  • Form Name Uses Lowercase View After Portal Type
  • Dialog Form Name Is Postfixed With Dialog
  • Report Name Uses Portal Type Followed By View Report Name And Report
  • Place Simulation And Validation Fields At Bottom Of Right Group
  • Use Correct Names For Simulation And Validation Titles

and apply minimal fixes to all business templates already running coding style checks.

Edited Dec 10, 2020 by Jérome Perrin
  • Discussion 3
  • Commits 56
  • Pipelines 12
  • Changes 256
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: nexedi/erp5!1021

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号