Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !126

Open
Created Jun 09, 2016 by Jérome Perrin@jeromeOwner
  • Report abuse
Report abuse

WIP: inconsistent listbox proxy fields for modules

  • Overview 2
  • Commits 1
  • Changes 1

Since 76282344 , most modules do not have a count method anymore.

But not all of them, because we have two proxy fields for listboxs , my_list_mode_listbox and my_view_mode_module_listbox that are not used consistently.

$ git grep  my_list_mode_listbox | wc -l
196
$ git grep  my_view_mode_module_listbox | wc -l
64

According to https://www.erp5.com/erp5-HowTo.Configure.Proxy.Field/erp5-Guideline.Form.Profixification/#the-semantic-field-name-needs-to-be-associated-with-the-technical-context the technical_context_name for module listbox is list_mode, so my understanding is that modules should not use my_view_mode_module_listbox because this is not view_mode, so my_list_mode_listbox sounds better.

I am planning to change all users of my_view_mode_module_listbox to use my_list_mode_listbox , but I would like to make sure my understanding is correct and we agree on this.

/cc @seb @vpelletier @gabriel @romain @jm @kazuhiko @yusei

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: listbox_module_proxy_field
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7