nexedi / erp5

@arnau all asynchronous code must be converted into promise, and ensure its result is handle (ie, returned by its parent function). Please try to convert this code with something like this:

function createNotification(title, body) {
  if ('Notification' in window) {
    return Notification.requestPermission()
      .then(function (result) {
        if (result === 'granted') {
          new Notification(title, {body: body}
        }
        // XXX Should it throw an error?
      });
  }
}

Fun fact, when using Chrome in Guest or Anonymous Mode, the browser do not request for authorisation to use notification and assume it should be denied. The only way to use notification then, is to manually go to preference and set the domain as authorized.

mentioned in merge request !766

@romain @arnau @cedric.leninivin can we merge !766 and close this one? :)

No, neither !704 or !766 can be merged as is currently, because they do not handle exceptions correctly.

added 1 commit

• be263316 - erp5.util.benchmark: Fix for recent versions of matplotlib.

Compare with previous version