Fix race in pushConn.

73f72c45 · Juliusz Chroboczek · 36d6845d · 73f72c45
Commit 73f72c45 authored Feb 02, 2021 by Juliusz Chroboczek
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

rtpconn/rtpconn.go rtpconn/rtpconn.go +2 -1

No files found.
--- a/rtpconn/rtpconn.go
+++ b/rtpconn/rtpconn.go
@@ -469,12 +469,13 @@ func pushConnNow(up *rtpUpConnection, g *group.Group, cs []group.Client) {
 // pushConn schedules a call to pushConnNow
 func pushConn(up *rtpUpConnection, g *group.Group, cs []group.Client) {
+	up.mu.Lock()
 	if up.complete() {
+		up.mu.Unlock()
 		pushConnNow(up, g, cs)
 		return
 	}
-	up.mu.Lock()
 	up.pushed = false
 	up.mu.Unlock()